Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide high-level taproot and musig2 abstractions #85

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jan 17, 2024

Expose helper functions added by ACINQ/bitcoin-kmp#107 to make it easier to create and spend taproot inputs.

@t-bast t-bast marked this pull request as ready for review January 17, 2024 15:29
@t-bast t-bast requested a review from sstone January 17, 2024 15:29
We provide helpers for spending taproot output via the key path or any
script path, without dealing with low-level details such as signature
version, control blocks or script execution context.

It makes it easier and less error-prone to spend taproot outputs in
higher level applications.
When using Musig2 for a taproot key path, we can provide simpler helper
functions to collaboratively build a shared signature for the spending
transaction.

This hides all of the low-level details of how the musig2 algorithm
works, by exposing a subset of what can be done that is sufficient for
spending taproot inputs.
This is an internal detail that shouldn't be exposed.
@t-bast t-bast force-pushed the taproot-musig2-abstractions branch from 7926ccc to 696503d Compare February 1, 2024 13:50
@t-bast
Copy link
Member Author

t-bast commented Feb 1, 2024

@sstone rebased to use the latest version of ACINQ/bitcoin-kmp#107

Copy link
Member

@sstone sstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

src/main/scala/fr/acinq/bitcoin/scalacompat/package.scala Outdated Show resolved Hide resolved
@sstone sstone merged commit 236b057 into master Feb 14, 2024
1 check passed
@sstone sstone deleted the taproot-musig2-abstractions branch February 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants